Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Do not throw on top-level property access (fixes #31854)

Browse Source
This commit is contained in:
Christof Marti
2017-08-01 15:25:07 -07:00
parent 3da10bb54d
commit 85fa81014e
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/api/node/extHost.api.impl.ts
View File

@@ -512,7 +512,7 @@ export function createApiFactory(
};
return {
const api: typeof vscode = {
version: pkg.version,
// namespaces
commands,
@@ -523,11 +523,7 @@ export function createApiFactory(
workspace,
scm,
debug,
get credentials() {
return proposedApiFunction(extension, () => {
return credentials;
})();
},
credentials,
// types
CancellationTokenSource: CancellationTokenSource,
CodeLens: extHostTypes.CodeLens,
@@ -581,6 +577,10 @@ export function createApiFactory(
Task: extHostTypes.Task,
ConfigurationTarget: extHostTypes.ConfigurationTarget
};
if (!extension.enableProposedApi) {
delete api.credentials; // Instead of error to avoid #31854
}
return api;
};
}