Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 20:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

filter perf marks that don't start with 'code/'

Browse Source
This commit is contained in:
Johannes Rieken
2021-01-12 12:43:49 +01:00
parent 675638196d
commit 868271067e
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/workbench/services/timer/browser/timerService.ts
View File

@@ -439,7 +439,9 @@ export abstract class AbstractTimerService implements ITimerService {
}
setPerformanceMarks(source: string, marks: perf.PerformanceMark[]): void {
this._marks.setMarks(source, marks);
// Perf marks are a shared resource because anyone can generate them
// and because of that we only accept marks that start with 'code/'
this._marks.setMarks(source, marks.filter(mark => mark.name.startsWith('code/')));
}
getPerformanceMarks(): [source: string, marks: readonly perf.PerformanceMark[]][] {
@@ -462,12 +464,12 @@ export abstract class AbstractTimerService implements ITimerService {
// event and it is "normalized" to a relative timestamp where the first mark
// defines the start
for (const [source, marks] of this.getPerformanceMarks()) {
type Mark = { source: string; name: string; relativeStartTime: number; startTime: number };
type Mark = { source: string; name: string; relativeStartTime: number; startTime: number; };
type MarkClassification = {
source: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth' },
name: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth' },
relativeStartTime: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth', isMeasurement: true },
startTime: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth', isMeasurement: true },
source: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth'; },
name: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth'; },
relativeStartTime: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth', isMeasurement: true; },
startTime: { classification: 'SystemMetaData', purpose: 'PerformanceAndHealth', isMeasurement: true; },
};
let lastMark: perf.PerformanceMark = marks[0];