From 86b60ec427472bef8a0ba7a6c209fb368df3331c Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 23 Nov 2021 16:12:12 +0100 Subject: [PATCH] tree dnd todos, https://github.com/microsoft/vscode/issues/32592 --- src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts b/src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts index 9db19f3260c..316d5b90a11 100644 --- a/src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts +++ b/src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts @@ -79,6 +79,7 @@ declare module 'vscode' { /** * Provides support for drag and drop in `TreeView`. */ + // TODO@api why disposable? export interface DragAndDropController extends Disposable { /** @@ -96,6 +97,7 @@ declare module 'vscode' { * * @param source The source items for the drag and drop operation. */ + // TODO@api I think this can be more generic, tho still constraint, e.g have something that works everywhere within VS Code onWillDrop?(source: T[]): Thenable; /** @@ -106,6 +108,7 @@ declare module 'vscode' { * @param source The data transfer items of the source of the drag. * @param target The target tree element that the drop is occuring on. */ + // TODO@api NIT - allow to return `Thenable | void` onDrop(source: TreeDataTransfer, target: T): Thenable; } }