From 8aef44b6426b37ccb22026f56f52f42d136f4a0a Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Wed, 24 Oct 2018 11:47:17 +0200 Subject: [PATCH] storage - fix "Log Storage" method to use Maps instead of Objects for case sensitivity issues --- .../platform/storage/node/storageService.ts | 28 ++++++++++++------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/src/vs/platform/storage/node/storageService.ts b/src/vs/platform/storage/node/storageService.ts index 9ee8cd2ef75..42104b60952 100644 --- a/src/vs/platform/storage/node/storageService.ts +++ b/src/vs/platform/storage/node/storageService.ts @@ -175,28 +175,36 @@ export class StorageService extends Disposable implements IStorageService { } }; - const globalItems = Object.create(null); - const globalItemsParsed = Object.create(null); + const globalItems = new Map(); + const globalItemsParsed = new Map(); result[0].forEach((value, key) => { - globalItems[key] = value; - globalItemsParsed[key] = safeParse(value); + globalItems.set(key, value); + globalItemsParsed.set(key, safeParse(value)); }); - const workspaceItems = Object.create(null); - const workspaceItemsParsed = Object.create(null); + const workspaceItems = new Map(); + const workspaceItemsParsed = new Map(); result[1].forEach((value, key) => { - workspaceItems[key] = value; - workspaceItemsParsed[key] = safeParse(value); + workspaceItems.set(key, value); + workspaceItemsParsed.set(key, safeParse(value)); }); console.group(`Storage: Global (check: ${result[2]}, load: ${getDuration('willInitGlobalStorage', 'didInitGlobalStorage')}, path: ${this.globalStorageWorkspacePath})`); - console.table(globalItems); + let globalValues = []; + globalItems.forEach((value, key) => { + globalValues.push({ key, value }); + }); + console.table(globalValues); console.groupEnd(); console.log(globalItemsParsed); console.group(`Storage: Workspace (check: ${result[3]}, load: ${getDuration('willInitWorkspaceStorage', 'didInitWorkspaceStorage')}, path: ${this.workspaceStoragePath})`); - console.table(workspaceItems); + let workspaceValues = []; + workspaceItems.forEach((value, key) => { + workspaceValues.push({ key, value }); + }); + console.table(workspaceValues); console.groupEnd(); console.log(workspaceItemsParsed);