Notebook Variable view follow-up (#198555)

* PR feedback follow-up

* fix API type issues
This commit is contained in:
Aaron Munger
2023-11-17 12:41:09 -08:00
committed by GitHub
parent 02f5ebe587
commit 8bc4783e37
6 changed files with 33 additions and 15 deletions

View File

@@ -9,7 +9,10 @@ declare module 'vscode' {
variableProvider?: NotebookVariableProvider;
}
type VariablesRequestKind = 'named' | 'indexed';
export enum NotebookVariablesRequestKind {
Named = 1,
Indexed = 2
}
interface VariablesResult {
variable: Variable;
@@ -21,7 +24,7 @@ declare module 'vscode' {
onDidChangeVariables: Event<void>;
/** When parent is undefined, this is requesting global Variables. When a variable is passed, it's requesting child props of that Variable. */
provideVariables(notebook: NotebookDocument, parent: Variable | undefined, kind: VariablesRequestKind, start: number, token: CancellationToken): AsyncIterable<VariablesResult>;
provideVariables(notebook: NotebookDocument, parent: Variable | undefined, kind: NotebookVariablesRequestKind, start: number, token: CancellationToken): AsyncIterable<VariablesResult>;
}
interface Variable {