From 8bd4a421c08522e6c393e66dcb40d080c70e9eb8 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 3 Mar 2023 08:28:18 +0100 Subject: [PATCH] smoke - fix electron window timeout (#176012) --- test/automation/src/playwrightElectron.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/automation/src/playwrightElectron.ts b/test/automation/src/playwrightElectron.ts index 61a250f20ea5..99ce47baaba2 100644 --- a/test/automation/src/playwrightElectron.ts +++ b/test/automation/src/playwrightElectron.ts @@ -17,12 +17,12 @@ export async function launch(options: LaunchOptions): Promise<{ electronProcess: args.push('--enable-smoke-test-driver'); // Launch electron via playwright - const { electron, context, page, windowLoadedPromise } = await launchElectron({ electronPath, args, env }, options); + const { electron, context, page } = await launchElectron({ electronPath, args, env }, options); const electronProcess = electron.process(); return { electronProcess, - driver: new PlaywrightDriver(electron, context, page, undefined /* no server process */, windowLoadedPromise, options) + driver: new PlaywrightDriver(electron, context, page, undefined /* no server process */, Promise.resolve() /* Window is open already */, options) }; } @@ -35,8 +35,6 @@ async function launchElectron(configuration: IElectronConfiguration, options: La env: configuration.env as { [key: string]: string } }), 'playwright-electron#launch', logger); - const windowLoadedPromise = electron.waitForEvent('window'); - const window = await measureAndLog(() => electron.firstWindow(), 'playwright-electron#firstWindow', logger); const context = window.context(); @@ -74,5 +72,5 @@ async function launchElectron(configuration: IElectronConfiguration, options: La } }); - return { electron, context, page: window, windowLoadedPromise }; + return { electron, context, page: window }; }