diff --git a/src/vs/code/electron-browser/issue/issueReporterMain.ts b/src/vs/code/electron-browser/issue/issueReporterMain.ts index 1101a52ed27..2f35e2b14a2 100644 --- a/src/vs/code/electron-browser/issue/issueReporterMain.ts +++ b/src/vs/code/electron-browser/issue/issueReporterMain.ts @@ -519,7 +519,7 @@ export class IssueReporter extends Disposable { this.logService.warn('issueReporter#search ', error.message); /* __GDPR__ "issueReporterSearchError" : { - "message" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } + "message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" } } */ this.telemetryService.publicLog('issueReporterSearchError', { message: error.message }); diff --git a/src/vs/platform/extensionManagement/node/extensionGalleryService.ts b/src/vs/platform/extensionManagement/node/extensionGalleryService.ts index 6cef891ca00..9c883bbb82f 100644 --- a/src/vs/platform/extensionManagement/node/extensionGalleryService.ts +++ b/src/vs/platform/extensionManagement/node/extensionGalleryService.ts @@ -635,7 +635,7 @@ export class ExtensionGalleryService implements IExtensionGalleryService { "galleryService:requestError" : { "url" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "cdn": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + "message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" } } */ this.telemetryService.publicLog('galleryService:requestError', { url, cdn: true, message }); @@ -658,7 +658,7 @@ export class ExtensionGalleryService implements IExtensionGalleryService { "galleryService:requestError" : { "url" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "cdn": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + "message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" } } */ this.telemetryService.publicLog('galleryService:requestError', { url: fallbackUrl, cdn: false, message }); diff --git a/src/vs/platform/telemetry/browser/errorTelemetry.ts b/src/vs/platform/telemetry/browser/errorTelemetry.ts index 976335c3d81..140b0fbe8ab 100644 --- a/src/vs/platform/telemetry/browser/errorTelemetry.ts +++ b/src/vs/platform/telemetry/browser/errorTelemetry.ts @@ -145,12 +145,12 @@ export default class ErrorTelemetry { for (let error of this._buffer) { /* __GDPR__ "UnhandledError" : { - "message" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "name": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "stack": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "id": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "line": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "column": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } + "message" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, + "name": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, + "stack": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, + "id": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, + "line": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, + "column": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" } } */ // __GDPR__TODO__ what's the complete set of properties? diff --git a/src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts b/src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts index aaea3b00838..41379934444 100644 --- a/src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts +++ b/src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts @@ -35,7 +35,7 @@ export class NodeCachedDataManager implements IWorkbenchContribution { if (err) { /* __GDPR__ "cachedDataError" : { - "errorCode" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, + "errorCode" : { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, "path": { "classification": "CustomerContent", "purpose": "PerformanceAndHealth" } } */ diff --git a/src/vs/workbench/parts/debug/electron-browser/debugService.ts b/src/vs/workbench/parts/debug/electron-browser/debugService.ts index ea33985f058..fdad8c36e59 100644 --- a/src/vs/workbench/parts/debug/electron-browser/debugService.ts +++ b/src/vs/workbench/parts/debug/electron-browser/debugService.ts @@ -955,7 +955,7 @@ export class DebugService implements debug.IDebugService { /* __GDPR__ "debugMisconfiguration" : { "type" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "error": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + "error": { "classification": "CallstackOrException", "purpose": "FeatureInsight" } } */ this.telemetryService.publicLog('debugMisconfiguration', { type: configuration ? configuration.type : undefined, error: errorMessage }); diff --git a/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts b/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts index 7bdc6c25679..d6fd04b8204 100644 --- a/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts +++ b/src/vs/workbench/parts/debug/electron-browser/rawDebugSession.ts @@ -165,7 +165,7 @@ export class RawDebugSession extends V8Protocol implements debug.ISession { if (error && error.sendTelemetry) { /* __GDPR__ "debugProtocolErrorResponse" : { - "error" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + "error" : { "classification": "CallstackOrException", "purpose": "FeatureInsight" } } */ this.telemetryService.publicLog('debugProtocolErrorResponse', { error: telemetryMessage }); diff --git a/src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts b/src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts index cf803640afe..5cc2c739f7b 100644 --- a/src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts +++ b/src/vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts @@ -883,7 +883,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService { "extensionGallery:install" : { "success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, "duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, + "errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, "recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "${include}": [ "${GalleryExtensionTelemetryData}" @@ -894,7 +894,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService { "extensionGallery:update" : { "success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, "duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, + "errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, "recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "${include}": [ "${GalleryExtensionTelemetryData}" @@ -905,7 +905,7 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService { "extensionGallery:uninstall" : { "success": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, "duration" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, - "errorcode": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }, + "errorcode": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }, "recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "${include}": [ "${GalleryExtensionTelemetryData}" diff --git a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts index a51e9494010..6cb354478fd 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts @@ -618,7 +618,7 @@ class PreferencesRenderersController extends Disposable { } else { /* __GDPR__ "defaultSettings.searchError" : { - "message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, + "message": { "classification": "CallstackOrException", "purpose": "FeatureInsight" }, "filter": { "classification": "SystemMetaData", "purpose": "FeatureInsight" } } */ diff --git a/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts b/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts index 1af5ab42370..f75566bb048 100644 --- a/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts +++ b/src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts @@ -484,7 +484,7 @@ class WelcomePage { "from" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "extensionId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "outcome": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "error": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } + "error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" } } */ this.telemetryService.publicLog(strings.installedEvent, { @@ -519,7 +519,7 @@ class WelcomePage { "from" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "extensionId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, "outcome": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }, - "error": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } + "error": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" } } */ this.telemetryService.publicLog(strings.installedEvent, {