This commit is contained in:
Johannes Rieken
2021-02-24 15:31:03 +01:00
parent a63be52fde
commit 8d9b2e65bd
2 changed files with 38 additions and 15 deletions

View File

@@ -351,7 +351,6 @@ suite('Notebook Document', function () {
test('#117273, Add multiple outputs', async function () {
this.skip();
const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest');
const document = await vscode.notebook.openNotebookDocument(resource);
@@ -372,26 +371,13 @@ suite('Notebook Document', function () {
assert.deepStrictEqual(document.cells[0].outputs[0].outputs[0].metadata, { outputType: 'stream', streamName: 'stdout' });
const edit2 = new vscode.WorkspaceEdit();
// All of the following edit operations fail.
edit2.appendNotebookCellOutput(document.uri, 0, [
new vscode.NotebookCellOutput(
[new vscode.NotebookCellOutputItem('hello', '1', { outputType: 'stream', streamName: 'stderr' })],
{ outputType: 'stream', streamName: 'stderr' }
)
]);
// edit2.replaceNotebookCellOutput(document.uri, 0, [
// ...document.cells[0].outputs,
// new vscode.NotebookCellOutput([new vscode.NotebookCellOutputItem('hello', '1', { outputType: 'stream', streamName: 'stderr' })], { outputType: 'stream', streamName: 'stderr' })
// ]);
// edit2.replaceNotebookCellOutput(document.uri, 0, [
// ...document.cells[0].outputs,
// new vscode.NotebookCellOutput([new vscode.NotebookCellOutputItem('application/x.notebook.stream', '1', { outputType: 'stream', streamName: 'stderr' })], { outputType: 'stream', streamName: 'stderr' })
// ]);
// This wasn't working, i had to revert to using `replaceNotebookCellOutput` (could be because we had two output in the cell).
// edit2.appendNotebookCellOutputItems(document.uri, 0, document.cells[0].outputs[1].id, [
// new vscode.NotebookCellOutputItem('hello', 'Append to existing stderr when we have two outputs (one for stdout & one for stderr)', { outputType: 'stream', streamName: 'stderr' })
// ]);
success = await vscode.workspace.applyEdit(edit);
success = await vscode.workspace.applyEdit(edit2);
assert.ok(success);
assert.strictEqual(document.cells[0].outputs.length, 2);