From 8db72dd07f3eedcad0044d221cfb3a697dcf2142 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Wed, 30 Aug 2017 12:52:24 +0200 Subject: [PATCH] Fix #33440 --- .../workbench/api/electron-browser/mainThreadConfiguration.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/api/electron-browser/mainThreadConfiguration.ts b/src/vs/workbench/api/electron-browser/mainThreadConfiguration.ts index d1eb9a7daf6..36b5e975ef9 100644 --- a/src/vs/workbench/api/electron-browser/mainThreadConfiguration.ts +++ b/src/vs/workbench/api/electron-browser/mainThreadConfiguration.ts @@ -46,7 +46,8 @@ export class MainThreadConfiguration implements MainThreadConfigurationShape { } private writeConfiguration(target: ConfigurationTarget, key: string, value: any, resource: URI): TPromise { - return this._configurationEditingService.writeConfiguration(target ? target : this.deriveConfigurationTarget(key, resource), { key, value }, { donotNotifyError: true, scopes: { resource } }); + target = target !== null && target !== undefined ? target : this.deriveConfigurationTarget(key, resource); + return this._configurationEditingService.writeConfiguration(target, { key, value }, { donotNotifyError: true, scopes: { resource } }); } private deriveConfigurationTarget(key: string, resource: URI): ConfigurationTarget {