Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

⚡ list: fix list sorting to use numeric sorting

Browse Source
This commit is contained in:
Joao Moreno
2017-03-14 17:36:50 +01:00
parent 2f4b91324b
commit 8e285069c7
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/base/browser/ui/list/listWidget.ts
View File

@@ -285,7 +285,7 @@ class MouseController<T> implements IDisposable {
const newSelection = selection.filter(i => i !== focus);
if (selection.length === newSelection.length) {
this.list.setSelection([...newSelection, focus].sort());
this.list.setSelection([...newSelection, focus]);
} else {
this.list.setSelection(newSelection);
}
@@ -339,6 +339,8 @@ function exclusiveDisjunction(one: number[], other: number[]): number[] {
return result;
}
const numericSort = (a: number, b: number) => a - b;
export class List<T> implements ISpliceable<T>, IDisposable {
private static InstanceCount = 0;
@@ -453,9 +455,9 @@ export class List<T> implements ISpliceable<T>, IDisposable {
}
setSelection(indexes: number[]): void {
this.eventBufferer.bufferEvents(() => {
indexes = indexes.sort();
indexes = indexes.sort(numericSort);
this.eventBufferer.bufferEvents(() => {
const oldIndexes = this.selection.set(indexes);
const diffIndexes = exclusiveDisjunction(oldIndexes, indexes);
diffIndexes.forEach(i => this.view.splice(i, 1, [this.view.element(i)]));
@@ -484,9 +486,9 @@ export class List<T> implements ISpliceable<T>, IDisposable {
}
setFocus(indexes: number[]): void {
this.eventBufferer.bufferEvents(() => {
indexes = indexes.sort();
indexes = indexes.sort(numericSort);
this.eventBufferer.bufferEvents(() => {
const oldIndexes = this.focus.set(indexes);
const diffIndexes = exclusiveDisjunction(oldIndexes, indexes);
diffIndexes.forEach(i => this.view.splice(i, 1, [this.view.element(i)]));