diff --git a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts index 09d7f4d95f4..846e736c88f 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts @@ -494,8 +494,11 @@ export class ExtensionEditor extends EditorPane { reset(template.recommendation); const extRecommendations = this.extensionRecommendationsService.getAllRecommendationsWithReason(); if (extRecommendations[extension.identifier.id.toLowerCase()]) { - append(template.recommendation, $(`div${ThemeIcon.asCSSSelector(starEmptyIcon)}`)); - append(template.recommendation, $(`div.recommendation-text`, undefined, extRecommendations[extension.identifier.id.toLowerCase()].reasonText)); + const reasonText = extRecommendations[extension.identifier.id.toLowerCase()].reasonText; + if (reasonText) { + append(template.recommendation, $(`div${ThemeIcon.asCSSSelector(starEmptyIcon)}`)); + append(template.recommendation, $(`div.recommendation-text`, undefined, reasonText)); + } } else if (this.extensionIgnoredRecommendationsService.globalIgnoredRecommendations.indexOf(extension.identifier.id.toLowerCase()) !== -1) { append(template.recommendation, $(`div.recommendation-text`, undefined, localize('recommendationHasBeenIgnored', "You have chosen not to receive recommendations for this extension."))); } diff --git a/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts b/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts index d645c071be3..f6bf7ca7540 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionsWidgets.ts @@ -480,7 +480,7 @@ export class ExtensionHoverWidget extends ExtensionWidget { private getRecommendationMessage(extension: IExtension): string | undefined { const recommendation = this.extensionRecommendationsService.getAllRecommendationsWithReason()[extension.identifier.id.toLowerCase()]; - if (recommendation) { + if (recommendation?.reasonText) { const bgColor = this.themeService.getColorTheme().getColor(extensionButtonProminentBackground); return `$(${starEmptyIcon.id}) ${recommendation.reasonText}`; }