Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 20:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Allow trackobject to take undefined

Browse Source
This commit is contained in:
Matt Bierner
2019-03-07 11:48:21 -08:00
parent a92031dc02
commit 8ee3c9a484
2 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/api/electron-browser/mainThreadHeapService.ts
View File

@@ -21,7 +21,7 @@ export interface IHeapService {
/**
* Track gc-collection for the given object
*/
trackObject(obj: ObjectIdentifier): void;
trackObject(obj: ObjectIdentifier | undefined): void;
}
export class HeapService implements IHeapService {

14
src/vs/workbench/api/electron-browser/mainThreadLanguageFeatures.ts
View File

@@ -137,9 +137,7 @@ export class MainThreadLanguageFeatures implements MainThreadLanguageFeaturesSha
if (dto) {
dto.forEach(obj => {
this._heapService.trackObject(obj);
if (obj.command) {
this._heapService.trackObject(obj.command);
}
this._heapService.trackObject(obj.command);
});
}
return dto;
@@ -149,9 +147,7 @@ export class MainThreadLanguageFeatures implements MainThreadLanguageFeaturesSha
return this._proxy.$resolveCodeLens(handle, model.uri, codeLens, token).then(obj => {
if (obj) {
this._heapService.trackObject(obj);
if (obj.command) {
this._heapService.trackObject(obj.command);
}
this._heapService.trackObject(obj.command);
}
return obj;
});
@@ -274,11 +270,7 @@ export class MainThreadLanguageFeatures implements MainThreadLanguageFeaturesSha
provideCodeActions: (model: ITextModel, rangeOrSelection: EditorRange | Selection, context: modes.CodeActionContext, token: CancellationToken): Promise<modes.CodeAction[]> => {
return this._proxy.$provideCodeActions(handle, model.uri, rangeOrSelection, context, token).then(dto => {
if (dto) {
dto.forEach(obj => {
if (obj.command) {
this._heapService.trackObject(obj.command);
}
});
dto.forEach(obj => { this._heapService.trackObject(obj.command); });
}
return MainThreadLanguageFeatures._reviveCodeActionDto(dto);
});