Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-22 09:38:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix invalid command converter behaviour

Browse Source
This commit is contained in:
Johannes Rieken
2020-11-16 11:38:59 +01:00
parent 2b06004f0d
commit 8f9aeb83da
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/workbench/api/common/extHostCommands.ts
View File

@@ -276,7 +276,7 @@ export class CommandsConverter {
toInternal(command: vscode.Command | undefined, disposables: DisposableStore): ICommandDto | undefined;
toInternal(command: vscode.Command | undefined, disposables: DisposableStore): ICommandDto | undefined {
if (!command || !command.command) {
if (!command) {
return undefined;
}
@@ -287,6 +287,11 @@ export class CommandsConverter {
tooltip: command.tooltip
};
if (!command.command) {
// falsy command id -> return converted command but don't attempt any
// argument or API-command dance since this command won't run anyways
return result;
}
const apiCommand = this._lookupApiCommand(command.command);
if (apiCommand) {