Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-01 22:12:26 +01:00
Code Issues Packages Projects Releases Wiki Activity

* separate scroll dimensions and scroll positions

Browse Source 
* have explicit methods for changing the scroll position (delayed/smooth vs now/direct) that bubble up to the editor internals.
* have all other clients of ScrollableElement not use smooth scrolling
This commit is contained in:
Alex Dima
2017-08-21 18:25:03 +02:00
parent 5d91fc886a
commit 90377a73d4
24 changed files with 444 additions and 354 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/base/browser/ui/list/listView.ts
View File

@@ -124,7 +124,7 @@ export class ListView<T> implements IDisposable {
const scrollHeight = this.getContentHeight();
this.rowsContainer.style.height = `${scrollHeight}px`;
this.scrollableElement.updateState({ scrollHeight });
this.scrollableElement.setScrollDimensions({ scrollHeight });
return deleted.map(i => i.element);
}
@@ -134,8 +134,8 @@ export class ListView<T> implements IDisposable {
}
get renderHeight(): number {
const scrollState = this.scrollableElement.getScrollState();
return scrollState.height;
const scrollDimensions = this.scrollableElement.getScrollDimensions();
return scrollDimensions.height;
}
element(index: number): T {
@@ -164,7 +164,7 @@ export class ListView<T> implements IDisposable {
}
layout(height?: number): void {
this.scrollableElement.updateState({
this.scrollableElement.setScrollDimensions({
height: height || DOM.getContentHeight(this._domNode)
});
}
@@ -221,12 +221,12 @@ export class ListView<T> implements IDisposable {
}
getScrollTop(): number {
const scrollState = this.scrollableElement.getScrollState();
return scrollState.scrollTop;
const scrollPosition = this.scrollableElement.getScrollPosition();
return scrollPosition.scrollTop;
}
setScrollTop(scrollTop: number): void {
this.scrollableElement.updateState({ scrollTop });
this.scrollableElement.setScrollPosition({ scrollTop });
}
get scrollTop(): number {