From 90a52e87bcdb5cceefd86d5d319ae094131dafd2 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Mon, 23 Jan 2017 10:22:36 -0800 Subject: [PATCH] Remove waitOnExit option from Terminal API This may turn into an enum or change behavior soon pending on the result of task-terminal integration. Removing from the API until more thought has been put into it. Part of #15583 Part of #18661 --- src/vs/vscode.d.ts | 5 ----- src/vs/workbench/api/node/extHostTerminalService.ts | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index 63312799d8c..ff86f4a41a4 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -3739,11 +3739,6 @@ declare module 'vscode' { * Args for the custom shell executable, this does not work on Windows (see #8429) */ shellArgs?: string[]; - - /** - * Whether the terminal should wait on exit for a keypress before closing the instance. - */ - waitOnExit?: boolean; } /** diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index cfd48c75932..835244700f1 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -114,7 +114,7 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape { } public createTerminalFromOptions(options: vscode.TerminalOptions): vscode.Terminal { - let terminal = new ExtHostTerminal(this._proxy, options.name, options.shellPath, options.shellArgs, options.waitOnExit); + let terminal = new ExtHostTerminal(this._proxy, options.name, options.shellPath, options.shellArgs/*, options.waitOnExit*/); this._terminals.push(terminal); return terminal; }