Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use DisposableStore in a few more places

Browse Source 
- Also switches a few places that re-implemented Disposable with calls to `_register` instead
This commit is contained in:
Matt Bierner
2019-10-07 15:07:49 -07:00
parent 095358e3b2
commit 90f33ddc6d
9 changed files with 56 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/api/common/extHostApiCommands.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/
import { URI } from 'vs/base/common/uri';
import { IDisposable } from 'vs/base/common/lifecycle';
import { DisposableStore } from 'vs/base/common/lifecycle';
import * as vscode from 'vscode';
import * as typeConverters from 'vs/workbench/api/common/extHostTypeConverters';
import * as types from 'vs/workbench/api/common/extHostTypes';
@@ -27,7 +27,7 @@ export class ExtHostApiCommands {
}
private _commands: ExtHostCommands;
private _disposables: IDisposable[] = [];
private readonly _disposables = new DisposableStore();
private constructor(commands: ExtHostCommands) {
this._commands = commands;
@@ -288,7 +288,7 @@ export class ExtHostApiCommands {
private _register(id: string, handler: (...args: any[]) => any, description?: ICommandHandlerDescription): void {
const disposable = this._commands.registerCommand(false, id, handler, this, description);
this._disposables.push(disposable);
this._disposables.add(disposable);
}
/**