From 9130ebd22aa208dacc6fc12ccc84317ac5a15e4c Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 14 Jun 2023 10:08:17 -0700 Subject: [PATCH] Ensure pty host only adds --inspect when a port is set Fixes #185033 --- .../electron-main/electronPtyHostStarter.ts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts b/src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts index 963ed887aa7..72ab9b51824 100644 --- a/src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts +++ b/src/vs/platform/terminal/electron-main/electronPtyHostStarter.ts @@ -42,15 +42,10 @@ export class ElectronPtyHostStarter implements IPtyHostStarter { this.utilityProcess = new UtilityProcess(this._logService, NullTelemetryService, this._lifecycleMainService); const inspectParams = parsePtyHostDebugPort(this._environmentService.args, this._environmentService.isBuilt); - let execArgv: string[] | undefined = undefined; - if (inspectParams) { - execArgv = ['--nolazy']; - if (inspectParams.break) { - execArgv.push(`--inspect-brk=${inspectParams.port}`); - } else if (!inspectParams.break) { - execArgv.push(`--inspect=${inspectParams.port}`); - } - } + const execArgv = inspectParams.port ? [ + '--nolazy', + `--inspect${inspectParams.break ? '-brk' : ''}=${inspectParams.port}` + ] : undefined; this.utilityProcess.start({ type: 'ptyHost',