Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

progress - do not send entire IExtensionDescription around

Browse Source
This commit is contained in:
Benjamin Pasero
2022-01-11 12:59:56 +01:00
parent d5945d36ab
commit 913952ac2e
3 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/api/common/extHost.protocol.ts
View File

@@ -462,7 +462,7 @@ export interface MainThreadOutputServiceShape extends IDisposable {
export interface MainThreadProgressShape extends IDisposable {
$startProgress(handle: number, options: IProgressOptions, extension?: IExtensionDescription): Promise<void>;
$startProgress(handle: number, options: IProgressOptions, extensionId?: string): Promise<void>;
$progressReport(handle: number, message: IProgressStep): void;
$progressEnd(handle: number): void;
}

2
src/vs/workbench/api/common/extHostProgress.ts
View File

@@ -28,7 +28,7 @@ export class ExtHostProgress implements ExtHostProgressShape {
const { title, location, cancellable } = options;
const source = { label: localize('extensionSource', "{0} (Extension)", extension.displayName || extension.name), id: extension.identifier.value };
this._proxy.$startProgress(handle, { location: ProgressLocation.from(location), title, source, cancellable }, extension).catch(onUnexpectedExternalError);
this._proxy.$startProgress(handle, { location: ProgressLocation.from(location), title, source, cancellable }, !extension.isUnderDevelopment ? extension.identifier.value : undefined).catch(onUnexpectedExternalError);
return this._withProgress(handle, task, !!cancellable);
}