Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 19:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure we disable suggestions properly

Browse Source
This commit is contained in:
Matt Bierner
2018-07-20 14:32:21 -07:00
parent 9fb3229377
commit 91d55c965a
1 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
extensions/typescript-language-features/src/features/diagnostics.ts
View File

@@ -13,8 +13,6 @@ export enum DiagnosticKind {
Suggestion
}
const allDiagnosticKinds = [DiagnosticKind.Syntax, DiagnosticKind.Semantic, DiagnosticKind.Suggestion];
class FileDiagnostics {
private readonly _diagnostics = new Map<DiagnosticKind, vscode.Diagnostic[]>();
@@ -23,13 +21,6 @@ class FileDiagnostics {
public language: DiagnosticLanguage
) { }
public isEmpty(): boolean {
return allDiagnosticKinds.every(kind => {
const diagnostics = this._diagnostics.get(kind);
return !!(diagnostics && diagnostics.length);
});
}
public updateDiagnostics(
language: DiagnosticLanguage,
kind: DiagnosticKind,
@@ -58,26 +49,26 @@ class FileDiagnostics {
}
return [
...(this._diagnostics.get(DiagnosticKind.Syntax) || []),
...(this._diagnostics.get(DiagnosticKind.Semantic) || []),
...this.get(DiagnosticKind.Syntax),
...this.get(DiagnosticKind.Semantic),
...this.getSuggestionDiagnostics(settings),
];
}
private getSuggestionDiagnostics(settings: DiagnosticSettings) {
if (!this._diagnostics.get(DiagnosticKind.Suggestion)) {
return [];
}
const enableSuggestions = settings.getEnableSuggestions(this.language);
return this._diagnostics.get(DiagnosticKind.Suggestion)!.filter(x => {
if (enableSuggestions) {
return this.get(DiagnosticKind.Suggestion).filter(x => {
if (!enableSuggestions) {
// Still show unused
return x.tags && x.tags.indexOf(vscode.DiagnosticTag.Unnecessary) !== -1;
}
return true;
});
}
private get(kind: DiagnosticKind): vscode.Diagnostic[] {
return this._diagnostics.get(kind) || [];
}
}
interface LangaugeDiagnosticSettings {