From 92085e6d1f4e4d456db669481f72bbf2f936cb64 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Fri, 22 Apr 2016 16:59:29 +0200 Subject: [PATCH] allow to warn about missing service dependencies, #5653 --- .../platform/instantiation/common/instantiationService.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/vs/platform/instantiation/common/instantiationService.ts b/src/vs/platform/instantiation/common/instantiationService.ts index 86bed5695c3..2b9c881fd6d 100644 --- a/src/vs/platform/instantiation/common/instantiationService.ts +++ b/src/vs/platform/instantiation/common/instantiationService.ts @@ -127,6 +127,13 @@ export class InstantiationService implements IInstantiationService { } } + // // check for missing args + // for (let i = 0; i < serviceArgs.length; i++) { + // if (!serviceArgs[i]) { + // console.warn(`${desc.ctor.name} MISSES service dependency ${serviceDependencies[i].id}`, new Error().stack); + // } + // } + // now create the instance const argArray = [desc.ctor]; argArray.push(...staticArgs);