Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 09:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

don't forward changes for disposed kernels

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-07 14:37:30 +02:00
parent a4270b8b6f
commit 9221eb9697
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/workbench/api/common/extHostNotebookKernels.ts
View File

@@ -32,6 +32,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
const handle = this._handlePool++;
const that = this;
let isDisposed = false;
const commandDisposables = new DisposableStore();
const emitter = new Emitter<boolean>();
@@ -52,6 +53,9 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
// once per event loop execution
let tokenPool = 0;
const _update = () => {
if (isDisposed) {
return;
}
const myToken = ++tokenPool;
Promise.resolve().then(() => {
if (myToken === tokenPool) {
@@ -111,6 +115,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
return that._extHostNotebook.createNotebookCellExecution(uri, index, data.id)!;
},
dispose: () => {
isDisposed = true;
this._selectionState.delete(handle);
commandDisposables.dispose();
emitter.dispose();