From 9419cdcf892e0afa696fecdff758e79c3909bce2 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Fri, 5 Nov 2021 09:48:23 -0700 Subject: [PATCH] Remove scroll bar when setting fixed dimensions to dynamic --- .../workbench/contrib/terminal/browser/terminalInstance.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 9943af41351..888f1e58a90 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1621,7 +1621,11 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { return; } this._fixedRows = this._parseFixedDimension(rows); - this._addScrollbar(); + if (this._fixedRows || this._fixedCols) { + this._addScrollbar(); + } else { + this._removeScrollbar(); + } this._resize(); this.focus(); } @@ -1696,6 +1700,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } this._horizontalScrollbar.setScrollDimensions({ width: this.xterm.raw.element.clientWidth, + // TODO: Use const/property for padding scrollWidth: this._fixedCols * charWidth + 30 }); this._horizontalScrollbar.getDomNode().style.paddingBottom = '16px';