Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 19:44:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

add replaceNotebookMetadata (should become replaceMetadata) to NotebookEditorEdit, https://github.com/microsoft/vscode/issues/105283

Browse Source
This commit is contained in:
Johannes Rieken
2020-09-09 10:27:59 +02:00
parent 52a7a9ecfb
commit 951dd140b8
5 changed files with 56 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/vs/workbench/api/browser/mainThreadNotebook.ts
View File

@@ -153,14 +153,17 @@ export class MainThreadNotebooks extends Disposable implements MainThreadNoteboo
this.registerListeners();
}
async $tryApplyEdits(viewType: string, resource: UriComponents, modelVersionId: number, edits: ICellEditOperation[]): Promise<boolean> {
async $tryApplyEdits(_viewType: string, resource: UriComponents, modelVersionId: number, cellEdits: ICellEditOperation[], newMetadata: NotebookDocumentMetadata | undefined): Promise<boolean> {
const textModel = this._notebookService.getNotebookTextModel(URI.from(resource));
if (textModel) {
this._notebookService.transformEditsOutputs(textModel, edits);
return textModel.applyEdit(modelVersionId, edits, true);
if (!textModel) {
return false;
}
return false;
this._notebookService.transformEditsOutputs(textModel, cellEdits);
//TODO@rebornix should this go into applyEdit?
if (newMetadata) {
textModel.updateNotebookMetadata(newMetadata);
}
return textModel.applyEdit(modelVersionId, cellEdits, true);
}
async removeNotebookTextModel(uri: URI): Promise<void> {