centralize telemetry level (#131919)

* centralize telemetry level

* add comments and const enum
This commit is contained in:
SteVen Batten
2021-08-30 10:38:42 -07:00
committed by GitHub
parent 9c6b9f0bf5
commit 9525d0e1ed
7 changed files with 46 additions and 13 deletions

View File

@@ -11,6 +11,7 @@ import { Disposable } from 'vs/base/common/lifecycle';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
import { IProductService } from 'vs/platform/product/common/productService';
import { getTelemetryLevel, TelemetryLevel } from 'vs/platform/telemetry/common/telemetryUtils';
@extHostNamedCustomer(MainContext.MainThreadTelemetry)
export class MainThreadTelemetry extends Disposable implements MainThreadTelemetryShape {
@@ -29,7 +30,7 @@ export class MainThreadTelemetry extends Disposable implements MainThreadTelemet
this._proxy = extHostContext.getProxy(ExtHostContext.ExtHostTelemetry);
if (!this._environmenService.disableTelemetry && this._productService.enableTelemetry) {
if (getTelemetryLevel(this._productService, this._environmenService) !== TelemetryLevel.NONE) {
this._register(this._configurationService.onDidChangeConfiguration(e => {
if (e.affectedKeys.includes('telemetry.enableTelemetry')) {
this._proxy.$onDidChangeTelemetryEnabled(this.telemetryEnabled);
@@ -41,7 +42,7 @@ export class MainThreadTelemetry extends Disposable implements MainThreadTelemet
}
private get telemetryEnabled(): boolean {
if (this._environmenService.disableTelemetry || !this._productService.enableTelemetry) {
if (getTelemetryLevel(this._productService, this._environmenService) !== TelemetryLevel.USER) {
return false;
}