diff --git a/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts b/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts index beaeeb75ed31..d40b4b5c7d1e 100644 --- a/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts +++ b/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts @@ -107,7 +107,7 @@ export class SideBySideEditor extends BaseEditor { return false; } - private updateInput(oldInput: SideBySideEditorInput, newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken): void { + private updateInput(oldInput: SideBySideEditorInput, newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken): Thenable { if (!newInput.matches(oldInput)) { if (oldInput) { this.disposeEditors(); @@ -116,18 +116,15 @@ export class SideBySideEditor extends BaseEditor { return this.setNewInput(newInput, options, token); } else { - this.detailsEditor.setInput(newInput.details, null, token); - this.masterEditor.setInput(newInput.master, options, token); - - return void 0; + return TPromise.join([this.detailsEditor.setInput(newInput.details, null, token), this.masterEditor.setInput(newInput.master, options, token)]).then(() => void 0); } } - private setNewInput(newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken): void { + private setNewInput(newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken): Thenable { const detailsEditor = this._createEditor(newInput.details, this.detailsEditorContainer); const masterEditor = this._createEditor(newInput.master, this.masterEditorContainer); - this.onEditorsCreated(detailsEditor, masterEditor, newInput.details, newInput.master, options, token); + return this.onEditorsCreated(detailsEditor, masterEditor, newInput.details, newInput.master, options, token); } private _createEditor(editorInput: EditorInput, container: HTMLElement): BaseEditor { diff --git a/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts b/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts index 6dc7fdc34faf..a8541d4666ae 100644 --- a/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts +++ b/src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts @@ -111,9 +111,7 @@ export class KeybindingsEditor extends BaseEditor implements IKeybindingsEditor setInput(input: KeybindingsEditorInput, options: EditorOptions, token: CancellationToken): Thenable { return super.setInput(input, options, token) - .then(() => { - this.render(options && options.preserveFocus, token); - }); + .then(() => this.render(options && options.preserveFocus, token)); } clearInput(): void {