diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts index 916ac9d275f..05aa63ac63c 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminal.contribution.ts @@ -133,7 +133,7 @@ configurationRegistry.registerConfiguration({ 'terminal.integrated.lineHeight': { 'description': nls.localize('terminal.integrated.lineHeight', "Controls the line height of the terminal, this number is multipled by the terminal font size to get the actual line-height in pixels."), 'type': 'number', - 'default': 1.2 + 'default': 1 }, 'terminal.integrated.enableBold': { 'type': 'boolean', diff --git a/src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts b/src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts index 8fb8326d002..1863c01d2e5 100644 --- a/src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts +++ b/src/vs/workbench/parts/terminal/electron-browser/terminalConfigHelper.ts @@ -94,10 +94,7 @@ export class TerminalConfigHelper implements ITerminalConfigHelper { if (fontSize <= 0) { fontSize = EDITOR_FONT_DEFAULTS.fontSize; } - let lineHeight = terminalConfig.lineHeight ? Math.max(terminalConfig.lineHeight, 1) : DEFAULT_LINE_HEIGHT; - if (!lineHeight) { - lineHeight = DEFAULT_LINE_HEIGHT; - } + const lineHeight = terminalConfig.lineHeight ? Math.max(terminalConfig.lineHeight, 1) : DEFAULT_LINE_HEIGHT; return this._measureFont(fontFamily, fontSize, lineHeight); }