From 9a00a108a0b7437ee154a2f51ada43dfac3ea597 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Wed, 27 Jun 2018 17:16:05 +0200 Subject: [PATCH] Select whole value when valueSelection is undefined (fixes #52906) This reverts commit c205df5c77b03269f3181505754af65c87fce176. --- src/vs/workbench/browser/parts/quickinput/quickInput.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/browser/parts/quickinput/quickInput.ts b/src/vs/workbench/browser/parts/quickinput/quickInput.ts index 35ab51f2050..669ef71f18d 100644 --- a/src/vs/workbench/browser/parts/quickinput/quickInput.ts +++ b/src/vs/workbench/browser/parts/quickinput/quickInput.ts @@ -573,7 +573,7 @@ class InputBox extends QuickInput implements IInputBox { private _value = ''; private _valueSelection: Readonly<[number, number]>; - private valueSelectionUpdated = false; + private valueSelectionUpdated = true; private _placeholder: string; private _password = false; private _prompt: string; @@ -674,9 +674,7 @@ class InputBox extends QuickInput implements IInputBox { } if (this.valueSelectionUpdated) { this.valueSelectionUpdated = false; - this.ui.inputBox.select(this._valueSelection ? - { start: this._valueSelection[0], end: this._valueSelection[1] } : - { start: this.ui.inputBox.value.length, end: this.ui.inputBox.value.length }); + this.ui.inputBox.select(this._valueSelection && { start: this._valueSelection[0], end: this._valueSelection[1] }); } if (this.ui.inputBox.placeholder !== (this.placeholder || '')) { this.ui.inputBox.placeholder = (this.placeholder || '');