From 9a2949806a615af89af4ef902ea01c646f7f9015 Mon Sep 17 00:00:00 2001 From: Johannes Date: Wed, 6 Apr 2022 10:14:35 +0200 Subject: [PATCH] fix leaking observer, https://github.com/microsoft/vscode/issues/146841 --- .../languageStatus/browser/languageStatus.contribution.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/languageStatus/browser/languageStatus.contribution.ts b/src/vs/workbench/contrib/languageStatus/browser/languageStatus.contribution.ts index d6d4689d90e..867ebed9818 100644 --- a/src/vs/workbench/contrib/languageStatus/browser/languageStatus.contribution.ts +++ b/src/vs/workbench/contrib/languageStatus/browser/languageStatus.contribution.ts @@ -6,7 +6,7 @@ import 'vs/css!./media/languageStatus'; import * as dom from 'vs/base/browser/dom'; import { renderLabelWithIcons } from 'vs/base/browser/ui/iconLabel/iconLabels'; -import { DisposableStore, dispose } from 'vs/base/common/lifecycle'; +import { DisposableStore, dispose, toDisposable } from 'vs/base/common/lifecycle'; import Severity from 'vs/base/common/severity'; import { getCodeEditor, ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { localize } from 'vs/nls'; @@ -227,6 +227,7 @@ class EditorStatusContribution implements IWorkbenchContribution { } }); observer.observe(document.body, { childList: true, subtree: true }); + this._renderDisposables.add(toDisposable(() => observer.disconnect())); } } }