diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index 8c0d4a34046..e4578028d55 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -503,6 +503,7 @@ "./vs/workbench/parts/codeEditor/electron-browser/toggleWordWrap.ts", "./vs/workbench/parts/comments/common/commentModel.ts", "./vs/workbench/parts/comments/electron-browser/commentGlyphWidget.ts", + "vs/workbench/parts/comments/electron-browser/commentService.ts", "./vs/workbench/parts/emmet/browser/actions/showEmmetCommands.ts", "./vs/workbench/parts/emmet/browser/emmet.browser.contribution.ts", "./vs/workbench/parts/emmet/electron-browser/actions/expandAbbreviation.ts", diff --git a/src/vs/workbench/parts/comments/electron-browser/commentService.ts b/src/vs/workbench/parts/comments/electron-browser/commentService.ts index e802d811794..8623e77007c 100644 --- a/src/vs/workbench/parts/comments/electron-browser/commentService.ts +++ b/src/vs/workbench/parts/comments/electron-browser/commentService.ts @@ -37,8 +37,8 @@ export interface ICommentService { registerDataProvider(owner: number, commentProvider: DocumentCommentProvider): void; unregisterDataProvider(owner: number): void; updateComments(event: CommentThreadChangedEvent): void; - createNewCommentThread(owner: number, resource: URI, range: Range, text: string): Promise; - replyToCommentThread(owner: number, resource: URI, range: Range, thread: CommentThread, text: string): Promise; + createNewCommentThread(owner: number, resource: URI, range: Range, text: string): Promise; + replyToCommentThread(owner: number, resource: URI, range: Range, thread: CommentThread, text: string): Promise; editComment(owner: number, resource: URI, comment: Comment, text: string): Promise; deleteComment(owner: number, resource: URI, comment: Comment): Promise; getComments(resource: URI): Promise; @@ -94,21 +94,21 @@ export class CommentService extends Disposable implements ICommentService { this._onDidUpdateCommentThreads.fire(event); } - createNewCommentThread(owner: number, resource: URI, range: Range, text: string): Promise { + async createNewCommentThread(owner: number, resource: URI, range: Range, text: string): Promise { const commentProvider = this._commentProviders.get(owner); if (commentProvider) { - return commentProvider.createNewCommentThread(resource, range, text, CancellationToken.None); + return await commentProvider.createNewCommentThread(resource, range, text, CancellationToken.None); } return null; } - replyToCommentThread(owner: number, resource: URI, range: Range, thread: CommentThread, text: string): Promise { + async replyToCommentThread(owner: number, resource: URI, range: Range, thread: CommentThread, text: string): Promise { const commentProvider = this._commentProviders.get(owner); if (commentProvider) { - return commentProvider.replyToCommentThread(resource, range, thread, text, CancellationToken.None); + return await commentProvider.replyToCommentThread(resource, range, thread, text, CancellationToken.None); } return null; @@ -121,7 +121,7 @@ export class CommentService extends Disposable implements ICommentService { return commentProvider.editComment(resource, comment, text, CancellationToken.None); } - return null; + return Promise.resolve(void 0); } deleteComment(owner: number, resource: URI, comment: Comment): Promise {