Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

GitHub Enterprise Auth improvements (#165082)

Browse Source 
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes https://github.com/microsoft/vscode-pull-request-github/issues/3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
  * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  * misc style (`private` usage, better `disposable` handling)
This commit is contained in:
Tyler James Leonhardt
2022-10-31 12:18:54 -07:00
committed by GitHub
parent c60980ca7a
commit 9b3e147d6d
4 changed files with 88 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/github-authentication/package.json
View File

@@ -24,7 +24,10 @@
"capabilities": {
"virtualWorkspaces": true,
"untrustedWorkspaces": {
"supported": true
"supported": "limited",
"restrictedConfigurations": [
"github-enterprise.uri"
]
}
},
"contributes": {