diff --git a/src/vs/platform/terminal/common/terminal.ts b/src/vs/platform/terminal/common/terminal.ts index b59e48e7986..6557e21eb52 100644 --- a/src/vs/platform/terminal/common/terminal.ts +++ b/src/vs/platform/terminal/common/terminal.ts @@ -569,11 +569,6 @@ export interface ITerminalProfile { icon?: ThemeIcon | URI | { light: URI, dark: URI }; } -export interface ITerminalContributedProfile { - id: string; - icon?: string; -} - export interface ITerminalDimensionsOverride extends Readonly { /** * indicate that xterm must receive these exact dimensions, even if they overflow the ui! diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index dfa1b9d3d95..a1ccee65806 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -921,14 +921,16 @@ declare module 'vscode' { export namespace window { /** * Registers a provider for a contributed terminal profile. + * @param id The ID of the contributed terminal profile. + * @param provider The terminal profile provider. */ export function registerTerminalProfileProvider(id: string, provider: TerminalProfileProvider): Disposable; - // TODO: id -> profileId, profileType? } export interface TerminalProfileProvider { /** * Provide terminal profile options for the requested terminal. + * @param token A cancellation token that indicates the result is no longer needed. */ provideProfileOptions(token: CancellationToken): ProviderResult; } diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts index 0816dc881b4..dbf762e23b2 100644 --- a/src/vs/workbench/api/common/extHostTerminalService.ts +++ b/src/vs/workbench/api/common/extHostTerminalService.ts @@ -585,7 +585,6 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I } public registerProfileProvider(id: string, provider: vscode.TerminalProfileProvider): vscode.Disposable { - console.log('registerProfileProvider', id); if (this._profileProviders.has(id)) { throw new Error(`Terminal profile provider "${id}" already registered`); } @@ -607,12 +606,8 @@ export abstract class BaseExtHostTerminalService extends Disposable implements I throw new Error(`No terminal profile options provided for id "${id}"`); } if ('pty' in options) { - // TODO: Pass in split terminal option this.createExtensionTerminal(options, { isSplitTerminal }); } - // if (options.iconPath) { - // checkProposedApiEnabled(extension); - // } this.createTerminalFromOptions(options, { isSplitTerminal }); } diff --git a/src/vs/workbench/contrib/terminal/browser/terminalService.ts b/src/vs/workbench/contrib/terminal/browser/terminalService.ts index c5103367220..43faf1bef9e 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalService.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalService.ts @@ -984,13 +984,6 @@ export class TerminalService implements ITerminalService { if ('id' in value.profile) { await this.createContributedTerminalProfile(value.profile.id, !!(keyMods?.alt && activeInstance)); - // TODO: Pass in cwd here? cwd should probably still be inherited - // if (keyMods?.alt && activeInstance) { - // // create split, only valid if there's an active instance - // instance = this.splitInstance(activeInstance, slc); - // } else { - // instance = this.createTerminal(slc); - // } return; } else { if (keyMods?.alt && activeInstance) {