diff --git a/src/vs/base/browser/ui/list/listPaging.ts b/src/vs/base/browser/ui/list/listPaging.ts index cc6ff3a92bb..1aba4dc1f2c 100644 --- a/src/vs/base/browser/ui/list/listPaging.ts +++ b/src/vs/base/browser/ui/list/listPaging.ts @@ -4,7 +4,7 @@ *--------------------------------------------------------------------------------------------*/ import 'vs/css!./list'; -import { IDisposable } from 'vs/base/common/lifecycle'; +import { IDisposable, Disposable } from 'vs/base/common/lifecycle'; import { range } from 'vs/base/common/arrays'; import { IListVirtualDelegate, IListRenderer, IListEvent, IListContextMenuEvent } from './list'; import { List, IListStyles, IListOptions } from './listWidget'; @@ -32,7 +32,7 @@ class PagedRenderer implements IListRenderer { const data = this.renderer.renderTemplate(container); - return { data, disposable: { dispose: () => { } } }; + return { data, disposable: Disposable.None }; } renderElement(index: number, _: number, data: ITemplateData, height: number | undefined): void { diff --git a/src/vs/editor/test/browser/services/openerService.test.ts b/src/vs/editor/test/browser/services/openerService.test.ts index 6c50fcb5294..6f03b911e37 100644 --- a/src/vs/editor/test/browser/services/openerService.test.ts +++ b/src/vs/editor/test/browser/services/openerService.test.ts @@ -3,6 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; +import { Disposable } from 'vs/base/common/lifecycle'; import { URI } from 'vs/base/common/uri'; import { OpenerService } from 'vs/editor/browser/services/openerService'; import { TestCodeEditorService } from 'vs/editor/test/browser/editorTestServices'; @@ -15,8 +16,8 @@ suite('OpenerService', function () { const commandService = new (class implements ICommandService { _serviceBrand: undefined; - onWillExecuteCommand = () => ({ dispose: () => { } }); - onDidExecuteCommand = () => ({ dispose: () => { } }); + onWillExecuteCommand = () => Disposable.None; + onDidExecuteCommand = () => Disposable.None; executeCommand(id: string, ...args: any[]): Promise { lastCommand = { id, args }; return Promise.resolve(undefined); diff --git a/src/vs/platform/commands/common/commands.ts b/src/vs/platform/commands/common/commands.ts index e2e05318487..96523ce0450 100644 --- a/src/vs/platform/commands/common/commands.ts +++ b/src/vs/platform/commands/common/commands.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -import { IDisposable, toDisposable } from 'vs/base/common/lifecycle'; +import { IDisposable, toDisposable, Disposable } from 'vs/base/common/lifecycle'; import { TypeConstraint, validateConstraints } from 'vs/base/common/types'; import { ServicesAccessor, createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { Event, Emitter } from 'vs/base/common/event'; @@ -136,8 +136,8 @@ export const CommandsRegistry: ICommandRegistry = new class implements ICommandR export const NullCommandService: ICommandService = { _serviceBrand: undefined, - onWillExecuteCommand: () => ({ dispose: () => { } }), - onDidExecuteCommand: () => ({ dispose: () => { } }), + onWillExecuteCommand: () => Disposable.None, + onDidExecuteCommand: () => Disposable.None, executeCommand() { return Promise.resolve(undefined); } diff --git a/src/vs/platform/driver/browser/driver.ts b/src/vs/platform/driver/browser/driver.ts index f13d45a5f13..7027a0d37b6 100644 --- a/src/vs/platform/driver/browser/driver.ts +++ b/src/vs/platform/driver/browser/driver.ts @@ -3,7 +3,7 @@ * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ -import { IDisposable, toDisposable } from 'vs/base/common/lifecycle'; +import { Disposable, IDisposable } from 'vs/base/common/lifecycle'; import { BaseWindowDriver } from 'vs/platform/driver/browser/baseDriver'; class BrowserWindowDriver extends BaseWindowDriver { @@ -21,7 +21,5 @@ class BrowserWindowDriver extends BaseWindowDriver { export async function registerWindowDriver(): Promise { (window).driver = new BrowserWindowDriver(); - return toDisposable(() => { - return { dispose: () => { } }; - }); + return Disposable.None; } diff --git a/src/vs/platform/keybinding/test/common/abstractKeybindingService.test.ts b/src/vs/platform/keybinding/test/common/abstractKeybindingService.test.ts index e139fb775c6..84a31d13438 100644 --- a/src/vs/platform/keybinding/test/common/abstractKeybindingService.test.ts +++ b/src/vs/platform/keybinding/test/common/abstractKeybindingService.test.ts @@ -15,6 +15,7 @@ import { ResolvedKeybindingItem } from 'vs/platform/keybinding/common/resolvedKe import { USLayoutResolvedKeybinding } from 'vs/platform/keybinding/common/usLayoutResolvedKeybinding'; import { INotification, INotificationService, IPromptChoice, IPromptOptions, NoOpNotification, IStatusMessageOptions } from 'vs/platform/notification/common/notification'; import { NullTelemetryService } from 'vs/platform/telemetry/common/telemetryUtils'; +import { Disposable } from 'vs/base/common/lifecycle'; function createContext(ctx: any) { return { @@ -119,8 +120,8 @@ suite('AbstractKeybindingService', () => { let commandService: ICommandService = { _serviceBrand: undefined, - onWillExecuteCommand: () => ({ dispose: () => { } }), - onDidExecuteCommand: () => ({ dispose: () => { } }), + onWillExecuteCommand: () => Disposable.None, + onDidExecuteCommand: () => Disposable.None, executeCommand: (commandId: string, ...args: any[]): Promise => { executeCommandCalls.push({ commandId: commandId, diff --git a/src/vs/workbench/test/electron-browser/api/extHostMessagerService.test.ts b/src/vs/workbench/test/electron-browser/api/extHostMessagerService.test.ts index 307a8e3cf63..b3fe2988ec7 100644 --- a/src/vs/workbench/test/electron-browser/api/extHostMessagerService.test.ts +++ b/src/vs/workbench/test/electron-browser/api/extHostMessagerService.test.ts @@ -28,8 +28,8 @@ const emptyDialogService = new class implements IDialogService { const emptyCommandService: ICommandService = { _serviceBrand: undefined, - onWillExecuteCommand: () => ({ dispose: () => { } }), - onDidExecuteCommand: () => ({ dispose: () => { } }), + onWillExecuteCommand: () => Disposable.None, + onDidExecuteCommand: () => Disposable.None, executeCommand: (commandId: string, ...args: any[]): Promise => { return Promise.resolve(undefined); }