From 9df63af4eec827c00a24d4a0bbc7433b03e225da Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Tue, 23 Jan 2018 12:59:00 +0100 Subject: [PATCH] fix leak --- src/vs/platform/actions/browser/menuItemActionItem.ts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/vs/platform/actions/browser/menuItemActionItem.ts b/src/vs/platform/actions/browser/menuItemActionItem.ts index 93dad79a5e7..2ce14fddef7 100644 --- a/src/vs/platform/actions/browser/menuItemActionItem.ts +++ b/src/vs/platform/actions/browser/menuItemActionItem.ts @@ -227,4 +227,13 @@ export class MenuItemActionItem extends ActionItem { this._itemClassDispose = { dispose: () => this.$e.getHTMLElement().classList.remove('icon', iconClass) }; } } + + dispose(): void { + if (this._itemClassDispose) { + dispose(this._itemClassDispose); + this._itemClassDispose = undefined; + } + + super.dispose(); + } }