From 2598adc0ae772f057ff9064ef98b733068250665 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu, 8 Jan 2026 03:42:42 -0800 Subject: [PATCH 1/2] Simplify wsl profile detection regex Fixes #286138 --- src/vs/platform/terminal/node/terminalProfiles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vs/platform/terminal/node/terminalProfiles.ts b/src/vs/platform/terminal/node/terminalProfiles.ts index 0307c48a59d..22bc21ab7e1 100644 --- a/src/vs/platform/terminal/node/terminalProfiles.ts +++ b/src/vs/platform/terminal/node/terminalProfiles.ts @@ -359,8 +359,8 @@ async function getWslProfiles(wslPath: string, defaultProfileName: string | unde if (!distroOutput) { return []; } - const regex = new RegExp(/[\r?\n]/); - const distroNames = distroOutput.split(regex).filter(t => t.trim().length > 0 && t !== ''); + const regex = new RegExp(/\r?\n/); + const distroNames = distroOutput.split(regex).filter(t => t.trim().length > 0); for (const distroName of distroNames) { // Skip empty lines if (distroName === '') { From 5ba5b2fccb09deb0c9ffcc3b125418737dbe96d9 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Thu, 8 Jan 2026 03:56:57 -0800 Subject: [PATCH 2/2] Inline regex, don't use ctor --- src/vs/platform/terminal/node/terminalProfiles.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/vs/platform/terminal/node/terminalProfiles.ts b/src/vs/platform/terminal/node/terminalProfiles.ts index 22bc21ab7e1..ea98eb66fb0 100644 --- a/src/vs/platform/terminal/node/terminalProfiles.ts +++ b/src/vs/platform/terminal/node/terminalProfiles.ts @@ -359,8 +359,7 @@ async function getWslProfiles(wslPath: string, defaultProfileName: string | unde if (!distroOutput) { return []; } - const regex = new RegExp(/\r?\n/); - const distroNames = distroOutput.split(regex).filter(t => t.trim().length > 0); + const distroNames = distroOutput.split(/\r?\n/).filter(t => t.trim().length > 0); for (const distroName of distroNames) { // Skip empty lines if (distroName === '') {