Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 11:38:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

🎁 Add killOnServerStop to debug configuration (#163779)

Browse Source 
* 🎁 Add `killOnServerStop` to schema

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 📜 Add description for `killOnServerStop`

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Stop created debug session on server stop

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Push kill listeners into another disposable container

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🐛 Prevent leak when new debug session fails to start

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

* 🔨 Use more verbose name for debug session tracker ID

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>

Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
This commit is contained in:
Babak K. Shandiz
2022-11-17 17:50:08 +03:30
committed by GitHub
parent 328ed10651
commit 9f56e365d7
3 changed files with 128 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
extensions/debug-server-ready/package.json
View File

@@ -40,7 +40,8 @@
"additionalProperties": false,
"markdownDescription": "%debug.server.ready.serverReadyAction.description%",
"default": {
"action": "openExternally"
"action": "openExternally",
"killOnServerStop": false
},
"properties": {
"action": {
@@ -63,6 +64,11 @@
"type": "string",
"markdownDescription": "%debug.server.ready.uriFormat.description%",
"default": "http://localhost:%s"
},
"killOnServerStop": {
"type": "boolean",
"markdownDescription": "%debug.server.ready.killOnServerStop.description%",
"default": false
}
}
},
@@ -74,7 +80,8 @@
"action": "debugWithEdge",
"pattern": "listening on port ([0-9]+)",
"uriFormat": "http://localhost:%s",
"webRoot": "${workspaceFolder}"
"webRoot": "${workspaceFolder}",
"killOnServerStop": false
},
"properties": {
"action": {
@@ -103,6 +110,11 @@
"type": "string",
"markdownDescription": "%debug.server.ready.webRoot.description%",
"default": "${workspaceFolder}"
},
"killOnServerStop": {
"type": "boolean",
"markdownDescription": "%debug.server.ready.killOnServerStop.description%",
"default": false
}
}
},
@@ -112,7 +124,8 @@
"markdownDescription": "%debug.server.ready.serverReadyAction.description%",
"default": {
"action": "startDebugging",
"name": "<launch browser config name>"
"name": "<launch browser config name>",
"killOnServerStop": false
},
"required": [
"name"
@@ -138,6 +151,11 @@
"type": "string",
"markdownDescription": "%debug.server.ready.debugConfigName.description%",
"default": "Launch Browser"
},
"killOnServerStop": {
"type": "boolean",
"markdownDescription": "%debug.server.ready.killOnServerStop.description%",
"default": false
}
}
}