move signature verification to shared process (#232402)

This commit is contained in:
Sandeep Somavarapu
2024-10-28 11:42:14 +01:00
committed by GitHub
parent 3bfd5dd4e4
commit a14300ec9f
2 changed files with 1 additions and 21 deletions

View File

@@ -119,7 +119,6 @@ import { IAuxiliaryWindowsMainService } from '../../platform/auxiliaryWindow/ele
import { AuxiliaryWindowsMainService } from '../../platform/auxiliaryWindow/electron-main/auxiliaryWindowsMainService.js';
import { normalizeNFC } from '../../base/common/normalization.js';
import { ICSSDevelopmentService, CSSDevelopmentService } from '../../platform/cssDev/node/cssDevService.js';
import { ExtensionSignatureVerificationService, IExtensionSignatureVerificationService } from '../../platform/extensionManagement/node/extensionSignatureVerificationService.js';
/**
* The main VS Code application. There will only ever be one instance,
@@ -1115,11 +1114,6 @@ export class CodeApplication extends Disposable {
// Dev Only: CSS service (for ESM)
services.set(ICSSDevelopmentService, new SyncDescriptor(CSSDevelopmentService, undefined, true));
if (this.productService.quality !== 'stable') {
// extensions signature verification service
services.set(IExtensionSignatureVerificationService, new SyncDescriptor(ExtensionSignatureVerificationService, undefined, true));
}
// Init services that require it
await Promises.settled([
backupMainService.initialize(),
@@ -1161,13 +1155,6 @@ export class CodeApplication extends Disposable {
mainProcessElectronServer.registerChannel('userDataProfiles', userDataProfilesService);
sharedProcessClient.then(client => client.registerChannel('userDataProfiles', userDataProfilesService));
if (this.productService.quality !== 'stable') {
// Extension signature verification service
const extensionSignatureVerificationService = accessor.get(IExtensionSignatureVerificationService);
sharedProcessClient.then(client => client.registerChannel('signatureVerificationService',
ProxyChannel.fromService(extensionSignatureVerificationService, disposables)));
}
// Update
const updateChannel = new UpdateChannel(accessor.get(IUpdateService));
mainProcessElectronServer.registerChannel('update', updateChannel);