Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use electron-osx-sign instead of manual code signing (#97582)

Browse Source 
* fix: use electron-osx-sign instead of manual code signing

* build/gulpfile.vscode.darwin.js -> build/darwin/sign.ts

* fix script call in pipeline

* fix incorrect keychain path

* fix update path to entitlements

* sign children first

* move electron-osx-sign deps to build/

Co-authored-by: deepak1556 <hop2deep@gmail.com>
This commit is contained in:
João Moreno
2020-05-18 17:43:30 +02:00
committed by GitHub
parent 65f571bfb9
commit a1ddfae782
13 changed files with 247 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
build/lib/electron.ts
View File

@@ -19,12 +19,6 @@ const root = path.dirname(path.dirname(__dirname));
const product = JSON.parse(fs.readFileSync(path.join(root, 'product.json'), 'utf8'));
const commit = util.getVersion(root);
export function getElectronVersion(): string {
const yarnrc = fs.readFileSync(path.join(root, '.yarnrc'), 'utf8');
const target = /^target "(.*)"$/m.exec(yarnrc)![1];
return target;
}
const darwinCreditsTemplate = product.darwinCredits && _.template(fs.readFileSync(path.join(root, product.darwinCredits), 'utf8'));
function darwinBundleDocumentType(extensions: string[], icon: string) {
@@ -38,7 +32,7 @@ function darwinBundleDocumentType(extensions: string[], icon: string) {
}
export const config = {
version: getElectronVersion(),
version: util.getElectronVersion(),
productAppName: product.nameLong,
companyName: 'Microsoft Corporation',
copyright: 'Copyright (C) 2019 Microsoft. All rights reserved',
@@ -108,7 +102,7 @@ function getElectron(arch: string): () => NodeJS.ReadWriteStream {
}
async function main(arch = process.arch): Promise<void> {
const version = getElectronVersion();
const version = util.getElectronVersion();
const electronPath = path.join(root, '.build', 'electron');
const versionFile = path.join(electronPath, 'version');
const isUpToDate = fs.existsSync(versionFile) && fs.readFileSync(versionFile, 'utf8') === `${version}`;