From a315fd8f2efa1d2aba7d88f9115eabd0d6a30d73 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Tue, 9 Nov 2021 16:57:10 +0100 Subject: [PATCH] #133201 add more logging --- src/vs/platform/userDataSync/common/userDataSyncAccount.ts | 6 ++++-- .../userDataSync/browser/userDataSyncWorkbenchService.ts | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/platform/userDataSync/common/userDataSyncAccount.ts b/src/vs/platform/userDataSync/common/userDataSyncAccount.ts index 514e3d00e6c..1c5c6894c74 100644 --- a/src/vs/platform/userDataSync/common/userDataSyncAccount.ts +++ b/src/vs/platform/userDataSync/common/userDataSyncAccount.ts @@ -6,7 +6,7 @@ import { Emitter, Event } from 'vs/base/common/event'; import { Disposable } from 'vs/base/common/lifecycle'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; -import { IUserDataSyncStoreService } from 'vs/platform/userDataSync/common/userDataSync'; +import { IUserDataSyncLogService, IUserDataSyncStoreService } from 'vs/platform/userDataSync/common/userDataSync'; export interface IUserDataSyncAccount { readonly authenticationProviderId: string; @@ -39,10 +39,12 @@ export class UserDataSyncAccountService extends Disposable implements IUserDataS private wasTokenFailed: boolean = false; constructor( - @IUserDataSyncStoreService private readonly userDataSyncStoreService: IUserDataSyncStoreService + @IUserDataSyncStoreService private readonly userDataSyncStoreService: IUserDataSyncStoreService, + @IUserDataSyncLogService private readonly logService: IUserDataSyncLogService, ) { super(); this._register(userDataSyncStoreService.onTokenFailed(() => { + this.logService.info('Settings Sync auth token failed', this.account?.authenticationProviderId, this.wasTokenFailed); this.updateAccount(undefined); this._onTokenFailed.fire(this.wasTokenFailed); this.wasTokenFailed = true; diff --git a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts index 667b02954c4..d156f7dfea1 100644 --- a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts +++ b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts @@ -657,8 +657,10 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat if (this._cachedCurrentSessionId !== cachedSessionId) { this._cachedCurrentSessionId = cachedSessionId; if (cachedSessionId === undefined) { + this.logService.info('Settings Sync: Reset current session'); this.storageService.remove(UserDataSyncWorkbenchService.CACHED_SESSION_STORAGE_KEY, StorageScope.GLOBAL); } else { + this.logService.info('Settings Sync: Updated current session', cachedSessionId); this.storageService.store(UserDataSyncWorkbenchService.CACHED_SESSION_STORAGE_KEY, cachedSessionId, StorageScope.GLOBAL, StorageTarget.MACHINE); } }