diff --git a/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts b/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts index f68ca411bc7..059bffe8744 100644 --- a/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts +++ b/src/vs/platform/files/browser/indexedDBFileSystemProvider.ts @@ -63,8 +63,6 @@ export class IndexedDB { } - - class IndexedDBFileSystemProvider extends KeyValueFileSystemProvider { constructor(scheme: string, private readonly database: IDBDatabase, private readonly store: string) { diff --git a/src/vs/platform/files/common/fileService.ts b/src/vs/platform/files/common/fileService.ts index 500f5ffc6ff..fc4e543c263 100644 --- a/src/vs/platform/files/common/fileService.ts +++ b/src/vs/platform/files/common/fileService.ts @@ -26,19 +26,19 @@ export class FileService extends Disposable implements IFileService { private readonly BUFFER_SIZE = 64 * 1024; - constructor(@ILogService private logService: ILogService) { + constructor(@ILogService private readonly logService: ILogService) { super(); } //#region File System Provider - private _onDidChangeFileSystemProviderRegistrations = this._register(new Emitter()); + private readonly _onDidChangeFileSystemProviderRegistrations = this._register(new Emitter()); readonly onDidChangeFileSystemProviderRegistrations = this._onDidChangeFileSystemProviderRegistrations.event; - private _onWillActivateFileSystemProvider = this._register(new Emitter()); + private readonly _onWillActivateFileSystemProvider = this._register(new Emitter()); readonly onWillActivateFileSystemProvider = this._onWillActivateFileSystemProvider.event; - private _onDidChangeFileSystemProviderCapabilities = this._register(new Emitter()); + private readonly _onDidChangeFileSystemProviderCapabilities = this._register(new Emitter()); readonly onDidChangeFileSystemProviderCapabilities = this._onDidChangeFileSystemProviderCapabilities.event; private readonly provider = new Map(); @@ -146,10 +146,10 @@ export class FileService extends Disposable implements IFileService { //#endregion - private _onDidRunOperation = this._register(new Emitter()); + private readonly _onDidRunOperation = this._register(new Emitter()); readonly onDidRunOperation = this._onDidRunOperation.event; - private _onError = this._register(new Emitter()); + private readonly _onError = this._register(new Emitter()); readonly onError = this._onError.event; //#region File Metadata Resolving @@ -881,10 +881,10 @@ export class FileService extends Disposable implements IFileService { //#region File Watching - private _onDidFilesChange = this._register(new Emitter()); + private readonly _onDidFilesChange = this._register(new Emitter()); readonly onDidFilesChange = this._onDidFilesChange.event; - private activeWatchers = new Map(); + private readonly activeWatchers = new Map(); watch(resource: URI, options: IWatchOptions = { recursive: false, excludes: [] }): IDisposable { let watchDisposed = false; @@ -950,7 +950,7 @@ export class FileService extends Disposable implements IFileService { //#region Helpers - private writeQueues: Map> = new Map(); + private readonly writeQueues: Map> = new Map(); private ensureWriteQueue(provider: IFileSystemProvider, resource: URI): Queue { const { extUri } = this.getExtUri(provider); diff --git a/src/vs/platform/files/electron-browser/diskFileSystemProvider.ts b/src/vs/platform/files/electron-browser/diskFileSystemProvider.ts index de3211dae17..1ba8c20f3e4 100644 --- a/src/vs/platform/files/electron-browser/diskFileSystemProvider.ts +++ b/src/vs/platform/files/electron-browser/diskFileSystemProvider.ts @@ -15,7 +15,7 @@ export class DiskFileSystemProvider extends NodeDiskFileSystemProvider { constructor( logService: ILogService, - private electronService: IElectronService, + private readonly electronService: IElectronService, options?: IDiskFileSystemProviderOptions ) { super(logService, options); diff --git a/src/vs/platform/files/node/diskFileSystemProvider.ts b/src/vs/platform/files/node/diskFileSystemProvider.ts index df266edaa01..c551bcac9c2 100644 --- a/src/vs/platform/files/node/diskFileSystemProvider.ts +++ b/src/vs/platform/files/node/diskFileSystemProvider.ts @@ -46,7 +46,10 @@ export class DiskFileSystemProvider extends Disposable implements private readonly BUFFER_SIZE = this.options?.bufferSize || 64 * 1024; - constructor(private logService: ILogService, private options?: IDiskFileSystemProviderOptions) { + constructor( + private readonly logService: ILogService, + private readonly options?: IDiskFileSystemProviderOptions + ) { super(); } @@ -198,9 +201,9 @@ export class DiskFileSystemProvider extends Disposable implements } } - private mapHandleToPos: Map = new Map(); + private readonly mapHandleToPos: Map = new Map(); - private writeHandles: Set = new Set(); + private readonly writeHandles: Set = new Set(); private canFlush: boolean = true; async open(resource: URI, opts: FileOpenOptions): Promise { @@ -502,14 +505,14 @@ export class DiskFileSystemProvider extends Disposable implements //#region File Watching - private _onDidWatchErrorOccur = this._register(new Emitter()); + private readonly _onDidWatchErrorOccur = this._register(new Emitter()); readonly onDidErrorOccur = this._onDidWatchErrorOccur.event; - private _onDidChangeFile = this._register(new Emitter()); + private readonly _onDidChangeFile = this._register(new Emitter()); readonly onDidChangeFile = this._onDidChangeFile.event; private recursiveWatcher: WindowsWatcherService | UnixWatcherService | NsfwWatcherService | undefined; - private recursiveFoldersToWatch: { path: string, excludes: string[] }[] = []; + private readonly recursiveFoldersToWatch: { path: string, excludes: string[] }[] = []; private recursiveWatchRequestDelayer = this._register(new ThrottledDelayer(0)); private recursiveWatcherLogLevelListener: IDisposable | undefined;