#59322 Remove the options

This commit is contained in:
Sandeep Somavarapu
2018-09-25 17:02:20 +02:00
parent 515c90a9fe
commit a5580c3d51
3 changed files with 9 additions and 18 deletions

View File

@@ -122,21 +122,17 @@ export class ExtHostOutputService {
this._proxy = mainContext.getProxy(MainContext.MainThreadOutputService);
}
createOutputChannel(name: string, options?: { force?: boolean }): vscode.OutputChannel {
createOutputChannel(name: string): vscode.OutputChannel {
name = name.trim();
if (!name) {
throw new Error('illegal argument `name`. must not be falsy');
} else {
if (options && options.force) {
// Do not crash if logger cannot be created
try {
return new ExtHostOutputChannelBackedByFile(name, this._outputDir, this._proxy);
} catch (error) {
console.log(error);
return new ExtHostPushOutputChannel(name, this._proxy);
} else {
// Do not crash if logger cannot be created
try {
return new ExtHostOutputChannelBackedByFile(name, this._outputDir, this._proxy);
} catch (error) {
console.log(error);
return new ExtHostPushOutputChannel(name, this._proxy);
}
}
}
}