From a565d7e2e8682d47c3d6425f1de388b2a4e8937d Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 16 Apr 2020 17:39:34 -0700 Subject: [PATCH] Fix default custom editors no opening properly --- src/vs/workbench/contrib/customEditor/browser/customEditors.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/customEditor/browser/customEditors.ts b/src/vs/workbench/contrib/customEditor/browser/customEditors.ts index 6dd4a042ab2..35d2f659f3e 100644 --- a/src/vs/workbench/contrib/customEditor/browser/customEditors.ts +++ b/src/vs/workbench/contrib/customEditor/browser/customEditors.ts @@ -391,7 +391,7 @@ export class CustomEditorContribution extends Disposable implements IWorkbenchCo id?: string, ): IOpenEditorOverride | undefined { if (editor instanceof CustomEditorInput) { - if (editor.group === group.id && editor.viewType === id) { + if (editor.group === group.id && (editor.viewType === id || typeof id !== 'string')) { // No need to do anything return undefined; } else {