testing: test tag feedback

This commit is contained in:
Connor Peet
2021-09-01 14:52:07 -07:00
parent 850ebc87a9
commit a59631868a
14 changed files with 288 additions and 181 deletions

View File

@@ -1696,7 +1696,7 @@ export namespace TestItem {
uri: URI.revive(item.uri),
tags: (item.tags || []).map(t => {
const { tagId } = TestTag.denamespace(t);
return new types.TestTag(tagId, tagId);
return new types.TestTag(tagId);
}),
range: Range.to(item.range || undefined),
invalidateResults: () => undefined,
@@ -1728,11 +1728,11 @@ export namespace TestItem {
export namespace TestTag {
export function from(tag: vscode.TestTag): ITestTag {
return { id: tag.id, label: tag.label };
return { id: tag.id };
}
export function to(tag: ITestTag): vscode.TestTag {
return new types.TestTag(tag.id, tag.label);
return new types.TestTag(tag.id);
}
}

View File

@@ -3331,14 +3331,7 @@ export class TestMessage implements vscode.TestMessage {
@es5ClassCompat
export class TestTag implements vscode.TestTag {
constructor(
public readonly id: string,
public readonly label?: string,
) {
if (/\s/.test(id)) {
throw new Error(`Test tag ID "${id}" may not include whitespace`);
}
}
constructor(public readonly id: string) { }
}
//#endregion