Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make resolveExternalUri return just a plain uri instead of a disposable result

Browse Source 
For #81131

We had trouble coming up with cases where extensions could actually reliably dispose of the resolved uri
This commit is contained in:
Matt Bierner
2019-09-23 10:40:58 -07:00
parent 00983bcdf0
commit a62b7dabe7
5 changed files with 15 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/vs/workbench/api/common/extHost.protocol.ts
View File

@@ -744,8 +744,7 @@ export interface IOpenUriOptions {
export interface MainThreadWindowShape extends IDisposable {
$getWindowVisibility(): Promise<boolean>;
$openUri(uri: UriComponents, options: IOpenUriOptions): Promise<boolean>;
$resolveExternalUri(uri: UriComponents, options: IOpenUriOptions): Promise<{ readonly handle: number, readonly result: UriComponents }>;
$releaseResolvedExternalUri(handle: number): Promise<boolean>;
$resolveExternalUri(uri: UriComponents, options: IOpenUriOptions): Promise<UriComponents>;
}
// -- extension host