Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adjust md external header link diagnostic range (#152001)

Browse Source 
Fixes #151998

Makes errors for invalid headers on file links only cover the fragment range instead of the entire link range
This commit is contained in:
Matt Bierner
2022-06-14 00:39:49 -07:00
committed by GitHub
parent c46555d9c8
commit a658c04b0a
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/markdown-language-features/src/test/diagnostic.test.ts
View File

@@ -131,7 +131,7 @@ suite('markdown: Diagnostics', () => {
const diagnostics = await getComputedDiagnostics(doc1, new InMemoryWorkspaceMarkdownDocuments([doc1, doc2]));
assertDiagnosticsEqual(diagnostics, [
new vscode.Range(5, 6, 5, 35),
new vscode.Range(5, 14, 5, 35),
]);
});
@@ -236,7 +236,9 @@ suite('markdown: Diagnostics', () => {
// But we should be able to override the default
const manager = createDiagnosticsManager(contents, new MemoryDiagnosticConfiguration({ validateFragmentLinks: DiagnosticLevel.ignore, validateMarkdownFileLinkFragments: DiagnosticLevel.warning }));
const { diagnostics } = await manager.recomputeDiagnosticState(doc1, noopToken);
assert.deepStrictEqual(diagnostics.length, 1);
assertDiagnosticsEqual(diagnostics, [
new vscode.Range(1, 13, 1, 21),
]);
}
});