Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-03 06:51:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15679 from aozgaa/master

Browse Source 
Convert from 1- to 0-based indexing for TypeScript completion spans
This commit is contained in:
Dirk Bäumer
2016-11-17 18:04:56 -08:00
committed by GitHub
parent aebd3da097 2be3b848db
commit a6af151d6c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript/src/features/completionItemProvider.ts
View File

@@ -23,8 +23,10 @@ class MyCompletionItem extends CompletionItem {
this.sortText = entry.sortText;
this.kind = MyCompletionItem.convertKind(entry.kind);
if (entry.replacementSpan) {
let span = entry.replacementSpan;
this.textEdit = TextEdit.replace(new Range(span.start.line, span.start.offset, span.end.line, span.end.offset), entry.name);
let span: protocol.TextSpan = entry.replacementSpan;
// The indexing for the range returned by the server uses 1-based indexing.
// We convert to 0-based indexing.
this.textEdit = TextEdit.replace(new Range(span.start.line - 1, span.start.offset - 1, span.end.line - 1, span.end.offset - 1), entry.name);
}
}