Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 10:08:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up comments, fix some code review issues, and make the exit code optional throughout to make it clear that it isn't always a number

Browse Source
This commit is contained in:
Gabriel DeBacker
2019-02-17 09:18:41 -08:00
parent 27ff8463c0
commit a7565721ba
11 changed files with 34 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/vs/workbench/api/node/extHostTerminalService.ts
View File

@@ -288,7 +288,6 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
public get activeTerminal(): ExtHostTerminal { return this._activeTerminal; }
public get terminals(): ExtHostTerminal[] { return this._terminals; }
public get terminalRenderers(): ExtHostTerminalRenderer[] { return this._terminalRenderers; }
private readonly _onDidCloseTerminal: Emitter<vscode.Terminal> = new Emitter<vscode.Terminal>();
public get onDidCloseTerminal(): Event<vscode.Terminal> { return this._onDidCloseTerminal && this._onDidCloseTerminal.event; }
@@ -338,7 +337,7 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
throw new Error('Only expected instance extension host terminal type');
}
// Check to see if the extension host already knows about this terminal.
for (const terminalRenderer of this.terminalRenderers) {
for (const terminalRenderer of this._terminalRenderers) {
if (terminalRenderer._id === terminal._id) {
return terminalRenderer;
}