Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-30 05:21:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix parameter not being escaped

Browse Source 
Fixes #49057
This commit is contained in:
Matt Bierner
2018-05-30 10:44:20 -07:00
parent 8589b59ac4
commit a7a4c6cb6a
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/typescript-language-features/src/features/jsDocCompletionProvider.ts
View File

@@ -206,6 +206,7 @@ class TryCompleteJsDocCommand implements Command {
export function templateToSnippet(template: string): SnippetString {
// TODO: use append placeholder
let snippetIndex = 1;
template = template.replace(/\$/g, '\\$');
template = template.replace(/^\s*(?=(\/|[ ]\*))/gm, '');
template = template.replace(/^(\/\*\*\s*\*[ ]*)$/m, (x) => x + `\$0`);
template = template.replace(/\* @param([ ]\{\S+\})?\s+(\S+)\s*$/gm, (_param, type, post) => {

2
extensions/typescript-language-features/src/test/jsdocSnippet.test.ts
View File

@@ -70,7 +70,7 @@ suite('typescript.jsDocSnippet', () => {
[
'/**',
' * $0',
' * @param $arg ${1}',
' * @param \\$arg ${1}',
' */'
].join('\n'));
});