From a82249586f2ecb480aaa74c6b908024f15519149 Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Fri, 9 Aug 2024 15:22:47 +1000 Subject: [PATCH] Avoid adding metadata keys that never existed (#225201) --- .../contrib/notebook/browser/diff/diffElementViewModel.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/notebook/browser/diff/diffElementViewModel.ts b/src/vs/workbench/contrib/notebook/browser/diff/diffElementViewModel.ts index 1e7d1fe38a7..793c7f89fa0 100644 --- a/src/vs/workbench/contrib/notebook/browser/diff/diffElementViewModel.ts +++ b/src/vs/workbench/contrib/notebook/browser/diff/diffElementViewModel.ts @@ -512,7 +512,9 @@ export class SideBySideDiffElementViewModel extends DiffElementCellViewModelBase const modifiedMedataRaw = Object.assign({}, this.modified.metadata); const originalCellMetadata = this.original.metadata; for (const key of cellMetadataKeys) { - modifiedMedataRaw[key] = originalCellMetadata[key]; + if (key in originalCellMetadata) { + modifiedMedataRaw[key] = originalCellMetadata[key]; + } } this.modified.textModel.metadata = modifiedMedataRaw;