From a865e6691bbcfa842ff95bd3f06578decc2becbc Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Tue, 22 Jan 2019 07:47:00 -0800 Subject: [PATCH] Sanitize terminal environment variables --- src/vs/workbench/api/node/extHostTerminalService.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vs/workbench/api/node/extHostTerminalService.ts b/src/vs/workbench/api/node/extHostTerminalService.ts index c3b1d9a853e..90a3c7ad382 100644 --- a/src/vs/workbench/api/node/extHostTerminalService.ts +++ b/src/vs/workbench/api/node/extHostTerminalService.ts @@ -414,6 +414,10 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape { // terminalEnvironment.mergeEnvironments(env, envFromConfig); terminalEnvironment.mergeEnvironments(env, shellLaunchConfig.env); + // Sanitize the environment, removing any undesirable VS Code and Electron environment + // variables + terminalEnvironment.sanitizeEnvironment(env); + // Continue env initialization, merging in the env from the launch // config and adding keys that are needed to create the process terminalEnvironment.addTerminalEnvironmentKeys(env, platform.locale, terminalConfig.get('setLocaleVariables'));