From a87c73527ee22166db0340fd7ca69a9cef8684d3 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 7 Jun 2019 11:21:22 -0700 Subject: [PATCH] Remove extra work in DiagnosticSettings ctor The langauges map is written so that it is lazy. We do not need to pre-populate it --- .../src/features/diagnostics.ts | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/extensions/typescript-language-features/src/features/diagnostics.ts b/extensions/typescript-language-features/src/features/diagnostics.ts index 60e7aa35b6a..d5ef4ae4441 100644 --- a/extensions/typescript-language-features/src/features/diagnostics.ts +++ b/extensions/typescript-language-features/src/features/diagnostics.ts @@ -5,7 +5,7 @@ import * as vscode from 'vscode'; import { ResourceMap } from '../utils/resourceMap'; -import { DiagnosticLanguage, allDiagnosticLanguages } from '../utils/languageDescription'; +import { DiagnosticLanguage } from '../utils/languageDescription'; import * as arrays from '../utils/arrays'; function diagnosticsEquals(a: vscode.Diagnostic, b: vscode.Diagnostic): boolean { @@ -101,12 +101,6 @@ class DiagnosticSettings { private readonly _languageSettings = new Map(); - constructor() { - for (const language of allDiagnosticLanguages) { - this._languageSettings.set(language, DiagnosticSettings.defaultSettings); - } - } - public getValidate(language: DiagnosticLanguage): boolean { return this.get(language).validate; }